Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added connection monitor apis to network watcher swagger + examples #2223

Merged
merged 4 commits into from
Jan 9, 2018
Merged

Added connection monitor apis to network watcher swagger + examples #2223

merged 4 commits into from
Jan 9, 2018

Conversation

irrogozh
Copy link
Member

@irrogozh irrogozh commented Jan 8, 2018 •
edited
Loading

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

alvadb
alvadb suggested changes Jan 8, 2018
View reviewed changes
Copy link

@alvadb alvadb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review and resolve linter issues:
https://travis-ci.org/Azure/azure-rest-api-specs/jobs/326426266

@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/network/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 85
After the PR: Warning(s): 0 Error(s): 85

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/network/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 85
After the PR: Warning(s): 0 Error(s): 85

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@alvadb alvadb merged commit c008dd3 into Azure:master Jan 9, 2018
@AutorestCI AutorestCI mentioned this pull request Jan 9, 2018
Closed
@AutorestCI
Copy link

Build Status Azure/azure-sdk-for-ruby#1225

@AutorestCI AutorestCI mentioned this pull request Jan 9, 2018
Closed
@AutorestCI
Copy link

Build Status Azure/azure-sdk-for-python#1748

@irrogozh irrogozh mentioned this pull request Jan 10, 2018
Merged
9 tasks
@chandrasekarsrinivasan chandrasekarsrinivasan mentioned this pull request Jan 12, 2018
Merged
10 tasks
@azhao155 azhao155 mentioned this pull request Jan 30, 2018
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvadb alvadb alvadb approved these changes

Assignees

@alvadb alvadb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@irrogozh @azuresdkciprbot @AutorestCI @alvadb